feat: configure user JWT expiry#1637
Open
qiontoo wants to merge 2 commits into
Open
Conversation
Owner
|
Thanks for adding the configurable login JWT expiry. The direction looks good, but please tighten up two things before merge:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Add AUTH_JWT_EXPIRES_SECONDS to configure password-login user JWT lifetime.\n- Keep the existing 30-day default when the variable is absent or invalid.\n- Add regression coverage for the configured expiry.\n\nCloses #1094\n\n## Validation\n-
npm run test -- tests/server/user-auth.test.ts -t "uses AUTH_JWT_EXPIRES_SECONDS for issued login JWTs"\n-npm run test -- tests/server/user-auth.test.ts\n-npx tsc --noEmit -p packages/server/tsconfig.json\n-npm run harness:check\n-npm run build