Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update parameter parsing and fix dry_run #49

Closed
wants to merge 1 commit into from
Closed

Conversation

fsck
Copy link
Member

@fsck fsck commented Mar 3, 2019

Trying to fix #41 as discussed previously. Feel feel to push to this branch @Trolldemorted

@Trolldemorted
Copy link
Member

What has gotta be done?

Do we need a dry run? If it means 'not deploying', you can leave the servers empty, if it means 'not storing' it doesn't make much sense.

@fsck
Copy link
Member Author

fsck commented Mar 4, 2019

I would interpret it as do everything but deploy. This would also makes sense for our internal testing (I think), as we can do everything up until actually connecting over ssh, without a valid remote end.

What needs to be done: Testing it a bit more and fixing the docker container because looking at it again this morning I probably messed up the parameters in the entry point.

@Trolldemorted
Copy link
Member

I am not certain that a parameter for that does make sense. If you do not want to deploy, you can always add no servers or just not hit the deploy button.

@fsck
Copy link
Member Author

fsck commented Mar 4, 2019

Because we might actually want to preconfigure the targets but not actually run them in a preparation to an event or, more importantly, we want to actually exercise the code paths in tests without having an live remote available. We need to think about a sensible testing strategy anyway.

@fsck fsck closed this Mar 5, 2019
Trolldemorted added a commit that referenced this pull request Mar 5, 2019
fsck pushed a commit that referenced this pull request Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pick reasonable env var names
2 participants