Add Prometheus monitoring API and Docker configuration for #72 #266
Conversation
| - ./grafana/dashboards:/var/lib/grafana/dashboards | ||
| environment: | ||
| - GF_SECURITY_ADMIN_USER=admin | ||
| - GF_SECURITY_ADMIN_PASSWORD=erddapadmin |
There was a problem hiding this comment.
Users should be able to specify a custom value, falling back to a default.
| - GF_SECURITY_ADMIN_PASSWORD=erddapadmin | |
| - GF_SECURITY_ADMIN_PASSWORD=${GF_SECURITY_ADMIN_PASSWORD:-erddapadmin} |
| @@ -0,0 +1,41 @@ | |||
| version: '3.8' | |||
There was a problem hiding this comment.
Specification of compose file version is considered obsolete, see https://docs.docker.com/reference/compose-file/version-and-name/#version-top-level-element-obsolete
| version: '3.8' |
| ```bash | ||
| # Create Java API directories | ||
| mkdir -p "/Users/lareina/Desktop/erddp test/erddap/src/main/java/gov/noaa/pfel/erddap/monitoring/config" | ||
| mkdir -p "/Users/lareina/Desktop/erddp test/erddap/src/main/java/gov/noaa/pfel/erddap/monitoring/servlet" | ||
|
|
||
| # Create Docker configuration directories | ||
| mkdir -p "/Users/lareina/Desktop/erddp test/erddap/docker/prometheus/grafana/provisioning/datasources" | ||
| mkdir -p "/Users/lareina/Desktop/erddp test/erddap/docker/prometheus/grafana/provisioning/dashboards" | ||
| mkdir -p "/Users/lareina/Desktop/erddp test/erddap/docker/prometheus/grafana/dashboards" | ||
|
|
There was a problem hiding this comment.
Users shouldn't need to create these directories since they are being created by this pull request.
| ```bash | |
| # Create Java API directories | |
| mkdir -p "/Users/lareina/Desktop/erddp test/erddap/src/main/java/gov/noaa/pfel/erddap/monitoring/config" | |
| mkdir -p "/Users/lareina/Desktop/erddp test/erddap/src/main/java/gov/noaa/pfel/erddap/monitoring/servlet" | |
| # Create Docker configuration directories | |
| mkdir -p "/Users/lareina/Desktop/erddp test/erddap/docker/prometheus/grafana/provisioning/datasources" | |
| mkdir -p "/Users/lareina/Desktop/erddp test/erddap/docker/prometheus/grafana/provisioning/dashboards" | |
| mkdir -p "/Users/lareina/Desktop/erddp test/erddap/docker/prometheus/grafana/dashboards" |
| @@ -0,0 +1,41 @@ | |||
| version: '3.8' | |||
|
|
|||
| services: | |||
There was a problem hiding this comment.
I would suggest adding these containers to the docker-compose.yml file at the root of the project, perhaps in a profile that can be enabled or disabled specifically. Then prometheus.yml could target erddap:8080 by default and users wouldn't have to edit any files to get monitoring on their local stack.
We already have support for prometheus metrics available at erddap/metrics through the prometheus-metrics-exporter-servlet-jakarta. Are the java classes you added currently used for anything? |
Description
This PR adds a generic metrics API and Docker configuration for monitoring ERDDAP instances with Prometheus and Grafana.
Features
Implementation
gov.noaa.pfel.erddap.monitoringdocker/prometheus/This addresses the project requirements to build a Prometheus Server configuration that can monitor multiple ERDDAP instances.
Testing