Bugfix: field bundle initialisation can miss ungridded dimensions #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
In
med_methods_FB_initfields are now accessed by name instead of index. Accessing fields by index sometimes caused issues becausemed_methods_FB_initremovescpl_scalarsfrom the field name listlfieldNameList, but then accesses the fields from the input state by index when determining the ungridded dimensions. Unlesscpl_scalarsis the last field in the input state, this causes the wrong fields to be used when determining the ungridded dimensions of the output fields.Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #): #427
Are changes expected to change answers? No.
Any User Interface Changes (namelist or namelist defaults changes)? No.
Testing performed
This change has been tested on a custom configuration using coupling MOM, CICE, and UM on Gadi. Also the regression tests (3.11) have passed here: https://github.com/kieranricardo/CMEPS/actions/runs/13231723482/job/36929866604?pr=1