-
Notifications
You must be signed in to change notification settings - Fork 42
Add support for intake-esgf #2765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I'll work with you on this one @bouweandela 🍺 |
e91e383
to
9d67ed5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having a dive in this, bud - let me know how I can help!
f"but your configuration for project '{project}' contains " | ||
f"'{data_source}' of type '{type(data_source)}'." | ||
) | ||
raise TypeError(msg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we want to see if we can first convert it to a DataSource
before we toss it out the window
------- | ||
:obj:`typing.Iterable` of :obj:`esmvalcore.io.base.DataElement` | ||
The data elements that have been found. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an excellent addition - we are finally abstracting a data object that gets ingested by esmvalcore, and we generalize it: let's be careful how we implement this so it can be reused with little fuss for the future: I'd argue that "data that can be loaded" can be anything ie the most generic file object (not needing to be on disk, nor it needing it to be downloaded), so we can operate with object stores too
this one here ties in very well with this PR, bud #2785 - enjoy your time off 🏖️ |
Description
Add support for using intake-esgf to find input data.
Example configuration in esmvalcore/config/configurations/intake-esgf.yml
Related to #2584
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: