Support partial trie fetching and move mutable to trie-memory #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements two things and fixes several tests: * Support partial trie. DatabaseHandle is changed to allow returning Option, and all op fns will return Error::Require(hash) if one of the hash is missing in the database. Client can use this information to further retrieve the required hash and try again. * trie now contains a mostly stable interface. Mutable structs interface may change a lot, and they're moved to trie-memory crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements two things and fixes several tests:
Option, and all op fns will return Error::Require(hash) if one of
the hash is missing in the database. Client can use this information
to further retrieve the required hash and try again.
interface may change a lot, and they're moved to trie-memory crate.