Added iterator and const_iterator to etl::ipool #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwellbelove
reviewed
Mar 5, 2025
include/etl/ipool.h
Outdated
| typedef typename etl::conditional<is_const, const ipool, ipool>::type pool_type; | ||
| typedef typename etl::conditional<is_const, const char* const*, char**>::type pointer_type; | ||
|
|
||
| ipool_iterator(const ipool_iterator& other): |
There was a problem hiding this comment.
The style used in the ETL is:-
ipool_iterator(const ipool_iterator& other)
: p_current(other.p_current)
, p_pool(other.p_pool)
There was a problem hiding this comment.
I just pushed an adjustment that fixes it.
|
This feature is already available in https://github.com/rolandreichweinbmw/etlplus |
jwellbelove
changed the base branch from
master
to
pull-request/#1043-Added-iterator-and-const_iterator-to-etl--ipool
jwellbelove
merged commit 4204745
into
ETLCPP:pull-request/#1043-Added-iterator-and-const_iterator-to-etl--ipool
63 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have the use case of iterating over allocated chunks in pools. Therefore adding the respective iterators.