Expand PyWake submodel support with case-insensitive lookup#53
Draft
bjarketol wants to merge 2 commits intoEUFLOW:mainfrom
Draft
Expand PyWake submodel support with case-insensitive lookup#53bjarketol wants to merge 2 commits intoEUFLOW:mainfrom
bjarketol wants to merge 2 commits intoEUFLOW:mainfrom
Conversation
bjarketol
force-pushed
the
expand-pywake-submodel-support
branch
from
a1be602 to
32e7a1c
Compare
bjarketol
force-pushed
the
expand-pywake-submodel-support
branch
3 times, most recently
from
e27dd02 to
d2f074c
Compare
… deps, and NOJLocalDeficit alias - Make all wrapped tools (floris, pywake, wayve, foxes) optional dependencies - Add case-insensitive submodel name lookup across deficit, deflection, turbulence, superposition, rotor averaging, and blockage models - Add NOJLocalDeficit as a deficit model name alias alongside Jensen - Fix CI: skip floris on Python <3.10, fix numpy 2.x compat in wayve - Add comprehensive parametrized tests for all submodel configuration functions Co-Authored-By: Claude Opus 4.6 <[email protected]>
bjarketol
force-pushed
the
expand-pywake-submodel-support
branch
from
ae243ea to
1457d07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_normalize_name()for case-insensitive model name matching across all 6 submodel categoriesget_with_default()to preserve extra user keys with recursive mergekis provided fora=[k_a, k_b]modelsprint()calls withwarnings.warn()Closes #52
Test plan
test_pywake_submodels.pycovering all model mappings, case-insensitive matching, parameter passthrough, model instantiation, and error casestest_pywake.pypass with no regressions🤖 Generated with Claude Code