Eliminate redundant YAML+netCDF loads in run_api#58
Merged
mathieu7an merged 1 commit intoEUFLOW:mainfrom Mar 30, 2026
Merged
Conversation
Contributor
Author
|
@SchmJo @kilojoules Can one of you review this? |
Contributor
Author
|
Can someone merge this if everything looks good? |
bjarketol
force-pushed
the
fix/eliminate-redundant-yaml-loads-v2
branch
from
e79733e to
979a801
Compare
- Support PyWake >= 2.6 (SimpleYawModel exp parameter removal) - Fix Speedup axis ordering and Weibull flow case sampling - Use DensityCompensation instead of DensityScale for air density - Eliminate redundant YAML+netCDF loads in run_api - Fix validate_yaml double extension and string time coordinates - Update Python version docs to reflect 3.10-3.12 support Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
bjarketol
force-pushed
the
fix/eliminate-redundant-yaml-loads-v2
branch
from
979a801 to
b216188
Compare
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_api()was loading the full YAML+netCDF 4 times per simulation (validate → discard, load_yaml, then downstream runner validates + loads again). Now it loads once viavalidate_yaml()(which returns the loaded dict) and passes the dict to model runners, which skip their internal validate+load when receiving a dict.Depends on #57.
🤖 Generated with Claude Code