Remove google maps, use OpenStreetMap instead #88

yankee42 · 2020-12-08T12:22:23Z

In the triplog and also on the dashboard for last known position the map is not directly shown. There is a "why?" link which says:

[..]displaying the map costs also real money for me as a developer.[..]

That's strange... OpenStreetMap is free and... at least in my opinion also clearly superior to Google Maps. You can't find that this bad, because in the Android-App it is already OpenStreetMap. Why not use it on the Web UI as well?

Here is a PR to replace Google Maps with OSM. It's work in progress however. I have a problem with the Map not initially drawing. As soon as I resize the browser window a tiny bit, the map comes up fine. Why? I have never worked with vue, so in case it has to do with something that Vue does I wouldn't know. (For that matter, the last time I coded plain JavaScript or used OpenLayers is many years ago...). So maybe another pair of eyes can see what I cannot see?

BTW: A little confusing: Some files are indented with 4 spaces, others with 2 spaces. I didn't really know what to do...

I also added some typedefs for the Log. I get totally lost without automatic code completion ;-). However some values seem to be always null for me. Maybe you got some improvements there.

hound · 2020-12-08T12:22:26Z

src/utils/EvNotifyMap.js

+    return feature;
+}
+
+export default EvNotifyMap;


'export' is only available in ES6 (use 'esversion: 6').

hound · 2020-12-08T12:22:26Z

src/utils/EvNotifyMap.js

+
+function createMarker(coordinates, src) {
+    const feature = new Feature({geometry: new Point(coordinates)});
+    feature.setStyle(new Style({image: new Icon({src, anchor: [0.5, 1]})}));


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2020-12-08T12:22:26Z

src/utils/EvNotifyMap.js

+};
+
+function createMarker(coordinates, src) {
+    const feature = new Feature({geometry: new Point(coordinates)});


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2020-12-08T12:22:27Z

src/utils/EvNotifyMap.js

+        })
+    }));
+    this.map.on('click', event => {
+        this.map.forEachFeatureAtPixel(event.pixel, feature => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2020-12-08T12:22:27Z

src/utils/EvNotifyMap.js

+            features: [marker]
+        })
+    }));
+    this.map.on('click', event => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2020-12-08T12:22:28Z

src/utils/EvNotifyMap.js

+    const start = createMarker(coordinates[0], require('../assets/marker-start.svg'));
+    const end = createMarker(coordinates[coordinates.length - 1], require('../assets/marker-finish.svg'));
+    const pathDrivenLineString = new LineString(coordinates);
+    const pathDrivenFeature = new Feature({


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2020-12-08T12:22:28Z

src/utils/EvNotifyMap.js

+
+    const start = createMarker(coordinates[0], require('../assets/marker-start.svg'));
+    const end = createMarker(coordinates[coordinates.length - 1], require('../assets/marker-finish.svg'));
+    const pathDrivenLineString = new LineString(coordinates);


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2020-12-08T12:22:28Z

src/utils/EvNotifyMap.js

+        .map(value => fromLonLat([value.longitude, value.latitude]));
+
+    const start = createMarker(coordinates[0], require('../assets/marker-start.svg'));
+    const end = createMarker(coordinates[coordinates.length - 1], require('../assets/marker-finish.svg'));


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2020-12-08T12:22:28Z

src/utils/EvNotifyMap.js

+        .filter(value => value.longitude != null && value.latitude != null)
+        .map(value => fromLonLat([value.longitude, value.latitude]));
+
+    const start = createMarker(coordinates[0], require('../assets/marker-start.svg'));


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2020-12-08T12:22:29Z

src/utils/EvNotifyMap.js

+EvNotifyMap.prototype.addLog = function (log) {
+    const coordinates = log.stats
+        .filter(value => value.longitude != null && value.latitude != null)
+        .map(value => fromLonLat([value.longitude, value.latitude]));


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2020-12-08T13:55:50Z

src/utils/EvNotifyMap.js

+Popup.prototype.show = function (heading, contentHtml, feature) {
+    this.headingElement.innerText = heading;
+    this.bodyElement.innerHTML = contentHtml;
+    const extent = feature.getGeometry().getExtent();


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2020-12-08T13:55:50Z

src/utils/EvNotifyMap.js

+            });
+        });
+
+        this.bodyElement = element(root, 'div', body => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2020-12-08T13:55:50Z

src/utils/EvNotifyMap.js

+
+            element(head, 'a', closeElement => {
+                closeElement.setAttribute('href', 'javascript:void(0)');
+                closeElement.addEventListener('click', () => this.hide());


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2020-12-08T13:55:50Z

src/utils/EvNotifyMap.js

+            this.headingElement = element(head, 'h1');
+
+            element(head, 'a', closeElement => {
+                closeElement.setAttribute('href', 'javascript:void(0)');


Script URL.

hound · 2020-12-08T13:55:50Z

src/utils/EvNotifyMap.js

+            head.setAttribute('class', 'map-popup-head');
+            this.headingElement = element(head, 'h1');
+
+            element(head, 'a', closeElement => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2020-12-08T13:55:51Z

src/utils/EvNotifyMap.js

+import VectorSource from 'ol/source/Vector';
+import Point from 'ol/geom/Point';
+import {Icon, Style, Stroke} from 'ol/style';
+import MomentJS from 'moment';


'import' is only available in ES6 (use 'esversion: 6').

hound · 2020-12-08T13:55:52Z

src/utils/EvNotifyMap.js

+import Feature from 'ol/Feature';
+import VectorSource from 'ol/source/Vector';
+import Point from 'ol/geom/Point';
+import {Icon, Style, Stroke} from 'ol/style';


'import' is only available in ES6 (use 'esversion: 6').

hound · 2020-12-08T13:55:52Z

src/utils/EvNotifyMap.js

+import VectorLayer from 'ol/layer/Vector';
+import Feature from 'ol/Feature';
+import VectorSource from 'ol/source/Vector';
+import Point from 'ol/geom/Point';


'import' is only available in ES6 (use 'esversion: 6').

hound · 2020-12-08T13:55:52Z

src/utils/EvNotifyMap.js

+import LineString from 'ol/geom/LineString';
+import VectorLayer from 'ol/layer/Vector';
+import Feature from 'ol/Feature';
+import VectorSource from 'ol/source/Vector';


'import' is only available in ES6 (use 'esversion: 6').

hound · 2020-12-08T13:55:52Z

src/utils/EvNotifyMap.js

+import OSM from 'ol/source/OSM';
+import LineString from 'ol/geom/LineString';
+import VectorLayer from 'ol/layer/Vector';
+import Feature from 'ol/Feature';


'import' is only available in ES6 (use 'esversion: 6').

yankee42 requested a review from GPlay97 as a code owner December 8, 2020 12:22

hound bot reviewed Dec 8, 2020

View reviewed changes

remove google maps, use OpenStreetMap instead

78eacd7

yankee42 force-pushed the openstreetmap branch from 6f59f09 to 78eacd7 Compare December 8, 2020 13:55

hound bot reviewed Dec 8, 2020

View reviewed changes

Uh oh!

Remove google maps, use OpenStreetMap instead #88

Are you sure you want to change the base?

Remove google maps, use OpenStreetMap instead #88

Uh oh!

Conversation

yankee42 commented Dec 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yankee42 commented Dec 8, 2020 •

edited

Loading