EVCC: fix DCPreCharge finished transition#64
Open
barsnick wants to merge 1 commit into
Open
Conversation
The EV-side DCPreCharge state tracked completion on the state instance, while the first precharge request was created by the preceding cable-check state. This allowed the EVProcessing state to get out of sync and let PowerDelivery start without first sending a final DCPreChargeReq with EVProcessing set to Finished. Track the sent Finished precharge request at session scope, reset it when entering DCPreCharge, force the initial precharge request to Ongoing, and only transition to PowerDelivery after the SECC has answered the Finished DCPreChargeReq. Signed-off-by: Moritz Barsnick <moritz.barsnick@chargebyte.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | -4 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EV-side DCPreCharge state tracked completion on the state instance, while the first precharge request was created by the preceding cable-check state. This allowed the EVProcessing state to get out of sync and let PowerDelivery start without first sending a final DCPreChargeReq with EVProcessing set to Finished.
Describe your changes
Track the sent Finished precharge request at session scope, reset it when entering DCPreCharge, force the initial precharge request to Ongoing, and only transition to PowerDelivery after the SECC has answered the Finished DCPreChargeReq.
Note: I'm not sure why the previous PRs #59 and #60 did not fix this, even though they say so.
Issue ticket number and link
Related to issue EVerest/EVerest#2305 and PR EVerest/EVerest#2312
Amends or fixes PR #59
Checklist before requesting a review