Add LiuNian & LiuYue generators with DaYun integration and unit tests#4
Open
cto-new[bot] wants to merge 1 commit intoPvfrom
Open
Add LiuNian & LiuYue generators with DaYun integration and unit tests#4cto-new[bot] wants to merge 1 commit intoPvfrom
cto-new[bot] wants to merge 1 commit intoPvfrom
Conversation
Introduce generators for annual (LiuNian) and monthly (LiuYue) pillars over user-specified ranges, associating each entry with corresponding DaYun cycles. - Expose robust utilities for pillar cycles, shifting, validation, and chronological filtering - Support filters by year/month range and precise DaYun linkage for each result - Provide comprehensive unit tests validating order, range filtering, and error handling - Add sample scenario and clear README instructions These utilities enable accurate generation and analysis of pillar sequences within Bazi/DaYun context. No breaking changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds robust generators for producing annual and monthly pillars (LiuNian and LiuYue) associated with DaYun cycles, including filtering, ordering, and full test coverage.
Details
generateLiuNianfor chronological annual pillar sequences within specified year ranges, with each entry linked to its DaYun cyclegenerateLiuYuefor chronological monthly pillar sequences within specified year/month ranges, with DaYun associationWarning: Task VM test is not passing, cto.new will perform much better if you fix the setup