feat: Calendar adapter for BaZi with 节气换年 and 晚子时 (late Zi hour) support#5
Open
cto-new[bot] wants to merge 1 commit intoPvfrom
Open
Conversation
Introduce a normalized Python adapter over lunar-python to compute BaZi pillars, handling solar term new-year (节气换年) rules and late 子时 (midnight rollover) distinctions. Includes structured representation of pillars and contextual metadata (solar term boundaries, leap months, sect flow, etc). Comprehensive tests cover boundaries and key edge cases. This enables reliable BaZi calculation in modern codebases with normalized input/output, robust across solar term and midnight transitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a Python calendar adapter that computes BaZi pillars using lunar-python, with explicit handling for solar-term new-year (节气换年) and proper late 子时 (midnight rollover) logic, exposing normalized API structures and comprehensive metadata.
Details
CalendarAdapterfacade insrc/calendar_adapterfor BaZi calculation with 节气换年 (solar term rollover) and 晚子时 (late Zi hour) logic.Warning: Task VM test is not passing, cto.new will perform much better if you fix the setup