Add BaZi Ten Gods computation module with typing and unit tests#6
Open
cto-new[bot] wants to merge 1 commit intoPvfrom
Open
Add BaZi Ten Gods computation module with typing and unit tests#6cto-new[bot] wants to merge 1 commit intoPvfrom
cto-new[bot] wants to merge 1 commit intoPvfrom
Conversation
Introduce the `bazi.ten_gods` module to calculate Ten Gods relationships between heavenly stems for BaZi (Four Pillars of Destiny). This module includes type hints throughout, a normalized day/other stem mapping utility, and thorough pytest-driven unit tests. This change enables type-checked, robust, and easily testable BaZi Ten Gods logic, supporting reliability for downstream consumers. No breaking changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new module for computing Ten Gods relationships between heavenly stems in BaZi, complete with type annotations and unit tests for correctness.
Details
bazi.ten_godswith typed dataclasses and computations for Ten Gods mapping.get_ten_godfunction for mapping day stem vs. other stem to labeled, coded result..gitignoreand ensures package structure ready for further extension.Warning: Task VM test is not passing, cto.new will perform much better if you fix the setup