Fix workspace member name from earn_quest to earn-quest to match actu…#401
Open
1sraeliteX wants to merge 1 commit intoEarnQuestOne:mainfrom
Open
Fix workspace member name from earn_quest to earn-quest to match actu…#4011sraeliteX wants to merge 1 commit intoEarnQuestOne:mainfrom
1sraeliteX wants to merge 1 commit intoEarnQuestOne:mainfrom
Conversation
Contributor
|
This is not link to any issue no, also resolve conflict |
Contributor
|
Kindly resolve conflict. If you do, you can still earn your points. Before the 7days review period. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…al directory
Linked Issue
Closes #
Description
What changed?
Why was it changed?
How was it implemented?
Type of Change
Test Evidence
Unit Tests
npm run test)npm run test:cov)Test output / screenshot:
E2E / Integration Tests
npm run test:e2e)Endpoints tested:
GET/api/…Swagger / API Documentation
@ApiOperation,@ApiResponse, and@ApiBearerAuthdecorators@ApiProperty/@ApiPropertyOptional/api/docsand responses are accurateError Handling Checklist
HTTP Exceptions
NotFoundException,BadRequestException,ForbiddenException,UnauthorizedException,ConflictException, etc.)Errorthrown where an HTTP exception is expectedInput Validation (DTOs)
class-validatordecorators (@IsString,@IsUUID,@IsNotEmpty,@IsOptional, etc.)class-transformerdecorators applied where necessary (@Transform,@Type,@Expose)ValidationPipeis applied globally or at the controller level — raw unvalidated input is never usedGuards & Authorization
@UseGuards(JwtAuthGuard)or equivalent@Public()decorator where applicableLogging
LoggerService)errorlevel with stack tracesLoggerMiddleware— no duplicate logs addedStellar / Soroban Contract Interactions
Database / Migration
npm run typeorm:generate-migration)seed.ts)Final Pre-Merge Checklist
main/masternpm run lint)npm run format)console.log/ debug statements left in production code.env.exampleupdated if new environment variables were introducedReadMe Backend.mdorReadMe Frontend.mdupdated if setup steps changedScreenshots / Recordings (if applicable)
Additional Notes for Reviewer