Skipmissing before starting the inner loop #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an indicator, that the run is probably correct. We might want to also include the checked result of a test run to the testdata folder and then compare against that one
Collaborator
Author
|
I added an indicator test that the main run was properly executed. This is currently only counting the number of significant pixels. I am wondering whether we should also include the result of a test run that we checked manually to the test data to then compare against so that we would get warned for certain changes in the results. @schlichtanders What is the purpose of the second run of the julia_main function in the test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we fixed the data loading so that the different scenes are already merged we should do a skipmissing before applying the inner loop.
This can be removed, once the data loading is fixed.