Only phone app branch #16
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,153 +1,18 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <title>Contacts</title> | ||
| <link href="https://fonts.googleapis.com/css?family=Oxygen" rel="stylesheet"> | ||
| <link href="css/bootstrap.css" rel="stylesheet"> | ||
| <link rel="stylesheet" href="css/main.css"> | ||
| </head> | ||
| <body> | ||
| <script src="src/js/model.js"></script> | ||
| <script src="src/js/view.js"></script> | ||
| <script src="src/js/controller.js"></script> | ||
| <script src="src/js/app.js"></script> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,18 @@ | ||
| class App{ | ||
| constructor(){ | ||
| this.state = "contacts" | ||
| this.model = new Model(this.state) | ||
| this.view = new View(this.state) | ||
| this.controller = new Controller(this.model,this.view) | ||
| } | ||
| render(){ | ||
| this.view.createStructure() | ||
| } | ||
| } | ||
|
|
||
| let app = new App() | ||
| app.render() | ||
|
|
||
|
|
||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| class Controller{ | ||
| constructor(model, view){ | ||
| this.model = model | ||
| this.view = view | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,59 @@ | ||
| class View{ | ||
| constructor(state){ | ||
| this.baseContainer = document.body | ||
| } | ||
| createHeader(){ | ||
| return ` | ||
| <header class="header"> | ||
| <div class="container top-radius"> | ||
| <h2>Contacts</h2> | ||
| </div> | ||
| </header> | ||
| ` | ||
| } | ||
|
|
||
| createContentBlock(){ | ||
| return `<main> | ||
| <div class="container"> | ||
| </div> | ||
| </main> | ||
| ` | ||
| } | ||
|
|
||
| createFooter(){ | ||
| return ` | ||
| <footer class="footer"> | ||
| <div class="container bottom-radius"> | ||
| <nav class="main-nav"> | ||
| <a href="index.html" class="tab active"> | ||
| <span class="glyphicon glyphicon-search" aria-hidden="true"></span> | ||
| <span class = "tab-text">Contacts</span> | ||
| </a> | ||
| <a href="keypad.html" class="tab"> | ||
| <span class="glyphicon glyphicon-th" aria-hidden="true"></span> | ||
| <span class = "tab-text">Keypad</span> | ||
| </a> | ||
| <a href="edit-contact.html" class="tab"> | ||
| <span class="glyphicon glyphicon-pencil" aria-hidden="true"></span> | ||
| <span class = "tab-text">Edit contact</span> | ||
| </a> | ||
| <a href="user.html" class="tab"> | ||
| <span class="glyphicon glyphicon-user" aria-hidden="true"></span> | ||
| <span class = "tab-text">User</span> | ||
| </a> | ||
| <a href="add-user.html" class="tab"> | ||
| <span class="glyphicon glyphicon-plus" aria-hidden="true"></span> | ||
| <span class = "tab-text">Add user</span> | ||
| </a> | ||
| </nav> | ||
| </div> | ||
| </footer> | ||
| ` | ||
| } | ||
|
|
||
| createStructure(){ | ||
| this.baseContainer.innerHTML += this.createHeader() | ||
|
||
| this.baseContainer.innerHTML += this.createContentBlock() | ||
| this.baseContainer.innerHTML += this.createFooter() | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not required to name it View. it could be a "mental abstraction" in your head.
On complex projects, MVC could be hidden, but from the relationships between classes/functions you would feel MVC :)
"it's smell like MVC"