add 0 Task + carousel, confused in numbers and called a branch of hom… #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * background-color | ||
| * */ | ||
|
|
||
| /* Не получилось */ |
Member
There was a problem hiding this comment.
а здесь дело в том, что получится только при помощи appendChild :)
OlegLustenko
requested changes
Jul 27, 2018
| list[i].style.left = nextPosition + 'px'; | ||
| let position = parseInt(list[i].style.left); | ||
| if (position === 0) { | ||
| list[i].classList.add('active') |
| } | ||
| start() { | ||
| /*Объявляем перменные */ | ||
| let carousel = document.querySelector(this.elementToApply); |
Member
There was a problem hiding this comment.
that method VERY BIG, can we split some logic to other methods?
| } | ||
| infinityCarousel () { | ||
| let last = this.list.length - 1; | ||
| if (!this.list[last].classList.contains('active')) { |
Member
There was a problem hiding this comment.
there a bunch of calculations, want to think about it optimization a bit
| this.list[i].style.left = nextPosition + 'px'; | ||
| let position = parseInt(this.list[i].style.left); | ||
| if (position === 0) { | ||
| this.list[i].classList.add('active') |
Member
There was a problem hiding this comment.
what about method toggle ? do you remember any ?:)
| this.list[i].classList.remove('active') | ||
| } | ||
| } | ||
| } else if (this.list[last].classList.contains('active') && this.infinity === true) { |
Member
There was a problem hiding this comment.
this.list[last].classList.contains('active') && this.infinity === true
well, having such conditionals is a tech-debt.
We can ask user for set default active element for example to avoid such construction or something else
Member
|
Here several things to improve but I think it's ready to merge |
OlegLustenko
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…emaking 18