Skip to content

Update the fix for smpp #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EbbDrop merged 3 commits into from
Jan 6, 2026
Merged

Update the fix for smpp #16

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8d4d1a
Update the fix for smpp
JJorne-JDEVJ May 6, 2025
d20edbc
Smpp fix p.2
JJorne-JDEVJ May 6, 2025
4e1d7b2
Remove debug log
EbbDrop Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions BetterStyle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,10 @@ chrome.storage.sync.get({
colortt: "#FFFFFF",
}, function (items) {
// Dedect smartschool++ and disable styles
const dmenu = document.getElementById("dmenu");
console.log(dmenu);
if (dmenu != null) {
// Update 06/05/25 => look for a settings page instead of dmenu as it should appear everywhere, whereas dmenu wont.
const smpp = document.getElementById("quickSettingsButton");
if (smpp != null) {
chrome.runtime.sendMessage({ smppDetected: smppActive }); // so we can inform people that themes have been disabled in the extention popup
return;
}

Expand All @@ -56,7 +57,7 @@ chrome.storage.sync.get({
let callback = function (mutationsList, observer) {
for (let mutation of mutationsList) {
for (let node of mutation.addedNodes) {
if (node.id != "dmenu") {
if (node.id != "quickSettingsButton") {
continue;
}
// smartschool++ was loaded after we created our style.
Expand Down