Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Écriture et comparaison ont lieu dans la même instance de composant #1222

Closed
wants to merge 1 commit into from

Conversation

thom4parisot
Copy link
Member

J'ai pas testé si le "state" du composant était cohérant en passant d'une route à l'autre (notamment quand on passe en comparaison de version / revient à l'écriture, etc.)

… composant

L'étape suivante ça serait d'avoir un `<Switch />` dans le composant, qui dirige vers la comparaison, l'écriture, la preview, etc.
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for stylo-docs canceled.

Name Link
🔨 Latest commit 2effbe5
🔍 Latest deploy log https://app.netlify.com/sites/stylo-docs/deploys/6798e0e346496c00077ad97a

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for stylo-dev ready!

Name Link
🔨 Latest commit 2effbe5
🔍 Latest deploy log https://app.netlify.com/sites/stylo-dev/deploys/6798e0e30479b500084d1cc9
😎 Deploy Preview https://deploy-preview-1222--stylo-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thom4parisot thom4parisot marked this pull request as draft January 28, 2025 16:49
@thom4parisot
Copy link
Member Author

C'est pas du tout bon ; ça flashe toujours.

Sûrement lié au fait qu'on redemande les données.
Comme on rend tous les éléments de la page conditionnels au fait que la requête a abouti, ça produit le flash.

C'est sûrement un bon écran candidat à swr / #1188 😎

@thom4parisot thom4parisot deleted the fix/compare-reload branch February 12, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant