Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supprime le champ user.admin #1265

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Supprime le champ user.admin #1265

merged 2 commits into from
Feb 13, 2025

Conversation

thom4parisot
Copy link
Member

@thom4parisot thom4parisot commented Feb 12, 2025

Les vérifications sont exclusivement effectuées à partir du token (on voit que c'était pas très très clair dans l'implémentation, d'ailleurs — un coup on vérifiait user.admin, un coup token.admin).

Les vérifications qui ont été modifiées concernent les requêtes GraphQL suivantes :

  • query
    • workspaces { … }
    • users { … } (🔴 supprimée, n'était utilisable qu'avec un jeton admin et on ne l'utilise pas pour l'interface avec stylo-export)
    • user { workspaces { … } }
    • workspace (workspaceId) { … }
  • mutation
    • corpus { … }
    • workspaces { … }

fixes #1264
refs #1147 (un bout raté lors d'un rebase en fin de soirée…)

Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for stylo-docs canceled.

Name Link
🔨 Latest commit 60a5308
🔍 Latest deploy log https://app.netlify.com/sites/stylo-docs/deploys/67ad9e3fc28a5500086abe5a

Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for stylo-dev ready!

Name Link
🔨 Latest commit 965c551
🔍 Latest deploy log https://app.netlify.com/sites/stylo-dev/deploys/67acae352f51d700072cdd5b
😎 Deploy Preview https://deploy-preview-1265--stylo-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Tout ce qui a trait à 'admin' concerne désormais uniquement le token.
@thom4parisot thom4parisot merged commit 72479bd into master Feb 13, 2025
8 checks passed
@thom4parisot thom4parisot deleted the fix/1264 branch February 13, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supprimer la notion de "compte admin" du modèle user
1 participant