This repository was archived by the owner on Oct 18, 2024. It is now read-only.
fix: handle testing environment using defaults #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddiejaoude
reviewed
Jul 13, 2024
| @@ -5,18 +5,22 @@ import config from "./flagsmith.json"; | |||
| export default async function flagsmith() { | |||
| const defaults = Object.fromEntries( | |||
| config.map((flag) => [ | |||
| [flag.name], | |||
| flag.name, | |||
eddiejaoude
reviewed
Jul 13, 2024
| } catch { | ||
| // Handle unable to connect to Flagsmith or not having valid environment | ||
| // Defaults will be used | ||
| } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #22
Changes proposed
Use try/catch to ignore flagsmith init error & use defaults
Don't run playwright as pre-commit as errors are hidden when using git in IDE (VSCode)
Check List (Check all the applicable boxes)