Fix button spinner + label on async pending state #5713
+52
−153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| : styles.labelTertiary, | ||
| children == null ? null : styles.labelWithIcon | ||
| ] | ||
| } |
There was a problem hiding this comment.
Bug: Inconsistent Visibility in Spinner/Pending States
The button's label now hides on spinner || pending, but the contentRowStyle (for icons/children) only hides on spinner. This inconsistency leaves icons visible alongside the spinner overlay when pending is true, while the label is hidden. Additionally, the labelInvisible style replaces labelBase, potentially losing includeFontPadding: false and causing subtle layout shifts.
Additional Locations (2)
There was a problem hiding this comment.
Not sure I fully understand this AI comment, but it might be worth double-checking.
swansontec
approved these changes
Aug 25, 2025
| : styles.labelTertiary, | ||
| children == null ? null : styles.labelWithIcon | ||
| ] | ||
| } |
There was a problem hiding this comment.
Not sure I fully understand this AI comment, but it might be worth double-checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: