Jon/rn79/swipe chart

[Jon-edge]

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

• Tested on iOS device
• Tested on Android device
• Tested on small-screen device (iPod Touch)
• Tested on large-screen device (tablet)

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1211038794778138

[swansontec]

const retryNavigation = (): void => { would be a simpler way to say the same thing

[swansontec]

Please remove this exception, and instead change the props variable to be called opts or something, inside handleGetPointerProps. The lint rule is picky about things called "props"

[swansontec]

The problem is that you have export const SwipeChart: React.FC<Props> = (params: Props) => {, which should instead be export const SwipeChart: React.FC<Props> = props => {. Notice the variable rename, and the type removal. With this change in place, ESLint is fine.

[Jon-edge]

Bug: Notification Prop Removal Affects Layout

The hasNotifications prop was removed from SceneWrapper in CoinRankingDetailsScene and CoinRankingScene. This change appears unrelated to the chart migration and likely disables intended notification functionality and its associated layout area.

src/components/scenes/CoinRankingScene.tsx#L333-L337
src/components/scenes/CoinRankingDetailsScene.tsx#L634-L635
 

This was an intentional cleanup. Scene already has no tabs, notifications were floating above some empty space.

Also, coinranking scenes are not showing any account-specific information, and there is a future ask to make it accessible outside of a logged in view.

Removing the notifications cleans up the experience where the user is trying to view a large amount of information on the screen at once.