Sam/fix ramp crash #5784
Open
Sam/fix ramp crash #5784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
samholmes
force-pushed
the
sam/fix-ramp-crash
branch
from
4a60bcd to
c8587ef
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
The previous implementation didn't check if `sortedQuotes[i]` was nullish and static types didn't complain. The solution is to use a reducer which is properly guarded by the existing sortedQuotes.length check.
For some reason some quotes were returning with zero amounts. This patches to at least not crash.
For some reason, FTM asset is not properly receiving an error from Simplex's API when the amount is below the minimum, but instead the API response is giving zero amounts for both crypto and fiat amounts. We'll treat these as a below minimum errors, because increasing the request amount to $50 or above fixes this for FTM.
samholmes
force-pushed
the
sam/fix-ramp-crash
branch
from
c8587ef to
fbf6956
Compare
| const bAmount = lastUsedInput === 'crypto' ? b.cryptoAmount : b.fiatAmount | ||
| return gt(bAmount, aAmount) ? b : a | ||
| }) | ||
| return picked |
There was a problem hiding this comment.
Bug: Invalid Numeric Strings Crash gt() Function
The maxQuoteForMaxFlow calculation's reduce function now passes cryptoAmount or fiatAmount strings directly to gt(). This removes the defensive handling that previously converted undefined, NaN, or malformed numeric strings to 0, potentially causing gt() to throw errors or crash with invalid input.
swansontec
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Prevents zero-amount Simplex quotes, improves max-amount quote selection with big-number comparison, and safely renders exchange-rate text (with new i18n).
src/components/scenes/RampCreateScene.tsx):biggystring.gtreduction to pick largest supportedcrypto/fiatamount.src/plugins/ramps/utils/getRateFromRampQuoteResult.ts):quote | undefined; return empty when undefined.lstrings.trade_option_invalid_quote_zero_cryptowhencryptoAmount === '0'.src/plugins/ramps/simplex/simplexRampPlugin.ts):fiat/cryptoamount quotes asunderLimitand reject early.trade_option_invalid_quote_zero_cryptotoen_US.tsandstrings/enUS.json.Written by Cursor Bugbot for commit fbf6956. This will update automatically on new commits. Configure here.