Sam/fix sell ramps max

[samholmes]

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

• Tested on iOS device
• Tested on Android device
• Tested on small-screen device (iPod Touch)
• Tested on large-screen device (tablet)

---

Note

Implements proper sell Max by using wallet max spend and passes an optional max cap to providers; updates UI and quote handling to use this and simplifies input disabling.

• UI/Scenes:
  • RampCreateScene: Implement async Max for sell by computing wallet max spend (getMaxSpendExchangeAmount) and setting exchangeAmount.max to a string cap; choose last-used input by direction. Replace sortedQuotes with allQuotes usages; simplify display logic and input disabling; support showing crypto amount from exchangeAmount.max when applicable.
• Types:
  • RampExchangeAmount.max now accepts string | true with docs (optional upper bound for provider max).
• Providers:
  • Banxa, Bity, Moonpay, Paybis, Revolut, Simplex: Treat max as a request flag and honor optional max cap; clamp computed max amounts to cap and adjust requests/quotes accordingly (including re-quoting for Revolut).

^{Written by Cursor Bugbot for commit 790fd1a. This will update automatically on new commits. Configure here.}

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1211608812309100
  • https://app.asana.com/0/0/1211699781252025

[samholmes]

This PR changed from using balance to using the max-spendable for a wallet for max sell feature. This is because the max amount that can be sold should account for fees.

[swansontec]

It would be nice to add a comment explaining the difference between the two.

[cursor]

Bug: Crypto Limits Applied Incorrectly to Fiat

The maxAmountLimit, which represents a crypto amount, is incorrectly applied to fiat amounts within the fetchQuotes function for both Moonpay and Paybis. This causes fiat transactions to be limited by crypto maximums, even when the amountType is 'fiat'.

Additional Locations (1)

• src/plugins/ramps/moonpay/moonpayRampPlugin.ts#L662-L665

 

[samholmes]

This is a corner-cut. We're assuming this API is only used for sell quotes for now (which it is). Maybe some TODO comments are warranted, but time is the constaint.