Skip to content

Conversation

@Jon-edge
Copy link
Collaborator

@Jon-edge Jon-edge commented Dec 4, 2025

Also fix grammar in sell string trade_sell_unavailable_body_1_2s

image image image

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Adds native-currency suggestions in ramp buy/sell flows when selected fiat mismatches country, with updated country data, strings, and types.

  • Ramps UI:
    • Show warning/suggestion in RampCreateScene when no quotes, appending native fiat suggestion via getUnavailableWarningBody(...).
    • Add warning suggestion AlertCardUi4 in RampSelectOptionScene to try other native fiats.
  • Data/Constants:
    • Extend COUNTRY_CODES with nativeIsoFiats for countries; update FIAT_COUNTRY logos as needed.
  • Types:
    • Add optional nativeIsoFiats?: string[] to CountryData.
  • i18n:
    • Fix sell copy (“sell … for …”) and add new strings: trade_check_fiat_1s, trade_check_fiat_title, trade_check_fiat_best_quote_body_2s.
  • Tests:
    • Update CountryListModal snapshot to include nativeIsoFiats.
  • Changelog:
    • Note added warning messaging for fiat/country mismatch in ramps.

Written by Cursor Bugbot for commit 749ba53. This will update automatically on new commits. Configure here.


@Jon-edge Jon-edge force-pushed the jon/ramp-fiat-mismatch branch from 6757fbf to 2faed77 Compare December 4, 2025 22:42
title={lstrings.trade_check_fiat_title}
body={nativeFiatSuggestion}
/>
) : null}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Warning message shown prematurely during loading state

The nativeFiatSuggestion AlertCard is rendered outside the showLoadingState conditional block, so it appears even while loading shimmer cards are displayed. The message text says "Quotes shown in %1$s. More quotes may be available in: %2$s." which is misleading during loading since no quotes have actually been shown yet - only placeholder shimmer cards. The suggestion alert renders at line 249-256 regardless of whether showLoadingState is true, creating a confusing UX where users see a message about "quotes shown" alongside loading placeholders.

Fix in Cursor Fix in Web

Copy link
Collaborator Author

@Jon-edge Jon-edge Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, the message is still valid even if quotes are loading. Also shimmer cards push the warning out anyway

Also fix grammar in sell string `trade_sell_unavailable_body_1_2s`
@Jon-edge Jon-edge force-pushed the jon/ramp-fiat-mismatch branch from 2faed77 to 749ba53 Compare December 5, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants