Fix length math #54
Merged
Fix length math #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
force-pushed
the
william/fix-length-math
branch
from
383496b to
79f7b25
Compare
jdowning100
approved these changes
Jul 5, 2025
Contributor
jdowning100
left a comment
jdowning100
left a comment
There was a problem hiding this comment.
Either way the numbers are the same, right - 131 bytes? Better to be explicit with constants, though.
paullinator
approved these changes
Jul 10, 2025
Contributor
Author
Yep, it's 131 constant now. Before, you could turn it into some other number by passing a too-short private key. |
swansontec
force-pushed
the
william/fix-length-math
branch
from
99d45c3 to
8ebeb8a
Compare
Contributor
Author
|
This is published as 2.2.1. @jdowning100, let me know if it works for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
The PR #53 pointed out a valid problem, but the math was still off. These lengths should be constant.