fix: implement real Soroban entitlement reads and cache freshness - #60
Merged
Conversation
Contributor
|
@dev-king-001 fix ci cd error before i will merge |
Contributor
|
Please resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: implement real Soroban entitlement reads and cache freshness
What was done
buildHasEntitlementXdranddecodeBooleanmethods insrc/lib/entitlement.jswith functional@stellar/stellar-sdkimplementations.entitlement_cachewith a 5-minute positive TTL and 1-minute negative TTL.PENDING_REQSPromise Map to coalesce overlapping verification requests and prevent RPC spikes.tests/backend/entitlement.test.mjsto accurately test the resilient fail-open fallback and TTL mechanics.Why it was done
How it was verified
npm run test:backend) passed successfully validating the positive/negative TTL limits, fail-open stale-cache behavior, and fallback mechanisms when the RPC is unavailable.Closes #5