Updated README and made source code more efficient #4
Open
otuva wants to merge 4 commits intoEgeBalci:masterfrom
Open
Updated README and made source code more efficient #4otuva wants to merge 4 commits intoEgeBalci:masterfrom
otuva wants to merge 4 commits intoEgeBalci:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'KEY' variable was declared 2 times. and condition for the 'KEY' in for loop was out of range.
The for loop is infinite because a char goes from -128 to +127, and thus never reaches 190. And using int inside for loop is inefficient. I put unsigned before char to make range 0 till 255 so condition can be viable.