Skip to content
This repository was archived by the owner on Apr 24, 2024. It is now read-only.

Feature/1168 creation and update times and ids of elements#1175

Open
horenso wants to merge 19 commits into
masterfrom
feature/1168-creation-and-update-times-and-ids-of-elements
Open

Feature/1168 creation and update times and ids of elements#1175
horenso wants to merge 19 commits into
masterfrom
feature/1168-creation-and-update-times-and-ids-of-elements

Conversation

@horenso

@horenso horenso commented Jan 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Basics

  • The PR is rebased with current master
  • I added a line to changelog.md
  • Details of what I changed are in the commit messages
  • References to issues, e.g. close #X, are in the commit messages and changelog
  • The buildserver is happy

Checklist

  • I fully described what my PR does in the documentation
  • I fixed all affected documentation
  • I fixed the introduction tour
  • I wrote migrations in a way that they are compatible with already present data
  • I fixed all affected decisions
  • I added automated tests or a manual test protocol
  • I added code comments, logging, and assertions as appropriate
  • I translated all strings visible to the user
  • I mentioned every code or binary not directly written or done by me in reuse syntax
  • I created left-over issues for things that are still to be done
  • Code is conforming to our Architecture
  • Code is conforming to our Guidelines
  • Code is consistent to our Design Decisions
  • Exceptions to any guidelines are documented

First Time Checklist

Review

  • I've tested the code
  • I've read through the whole code
  • I've read through the whole documentation
  • I've checked conformity to guidelines
  • I've checked conformity to requirements
  • I've checked that the requirements are tested

@horenso horenso linked an issue Jan 30, 2024 that may be closed by this pull request
creation and update times of elements #1168
Open
7 tasks
@horenso

horenso commented Jan 30, 2024

Copy link
Copy Markdown
Contributor Author

This ended up touching more files that I liked.

@horenso
horenso marked this pull request as draft January 30, 2024 01:32
@Bushuo
Bushuo force-pushed the feature/1168-creation-and-update-times-and-ids-of-elements branch from c7fc7cc to 3f271e4 Compare February 3, 2024 13:10
@horenso horenso added the please review Review by unspecified person requested label Feb 5, 2024
@horenso
horenso force-pushed the feature/1168-creation-and-update-times-and-ids-of-elements branch from b26bcc2 to d1c1ba2 Compare February 5, 2024 18:21
chr-schr
chr-schr reviewed Feb 9, 2024
View reviewed changes
Comment thread backend/src/schema_old.rs Outdated

@chr-schr chr-schr Feb 9, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this included for a reason or by mistake?

Comment thread frontend/src/features/map_planning/store/TrackedMapStore.ts Outdated
Comment on lines +24 to +42
setSingleNodeInTransformer: (node: Node) => {
get().transformer?.current?.nodes([node]);
},
addNodeToTransformer: (node: Node) => {
const currentNodes = get().transformer.current?.nodes() ?? [];
if (!currentNodes.includes(node)) {
get().transformer?.current?.nodes([...currentNodes, node]);
}
},
removeNodeFromTransformer: (node: Node) => {
const currentNodes = get().transformer.current?.nodes() ?? [];
const nodeToRemove = currentNodes.indexOf(node);

if (nodeToRemove !== -1) {
const newNodes = currentNodes.slice();
newNodes.splice(nodeToRemove, 1);
get().transformer.current?.nodes(newNodes);
}
},

@chr-schr chr-schr Feb 9, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 3 functions do not seem to be used anywhere?

Comment thread frontend/src/features/map_planning/layers/plant/actions.ts Outdated
}

constructor(private readonly _data: CreatePlantActionPayload[], public actionId = v4()) {
// TODO: Sollte hier beim constructor nicht NewPlantingDto verwendet werden?

@chr-schr chr-schr Feb 9, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO: Sollte hier beim constructor nicht NewPlantingDto verwendet werden?

@horenso
horenso force-pushed the feature/1168-creation-and-update-times-and-ids-of-elements branch from d1c1ba2 to bb87951 Compare February 10, 2024 01:49
@horenso

horenso commented Feb 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I cleaned up the PR now, it should be good now... (I know changelog is missing, will fix that in the evening when I'm on my PC)

@horenso
horenso requested review from Bushuo and markus2330 February 15, 2024 14:05
@horenso
horenso marked this pull request as ready for review February 15, 2024 14:06
@markus2330

markus2330 commented Feb 15, 2024

Copy link
Copy Markdown
Contributor

@horenso thx ❤️ Unfortunately, there is still one file conflicting ❓
Please also check if CI runs through.

@horenso
horenso force-pushed the feature/1168-creation-and-update-times-and-ids-of-elements branch from 7d91073 to 90a84f6 Compare February 16, 2024 00:08
@markus2330

markus2330 commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

CI unfortunately did not run through. Please tick the points in "Basics" or even "Checklist" if it makes sense.

@chr-schr
chr-schr self-requested a review February 18, 2024 13:42
@horenso
horenso force-pushed the feature/1168-creation-and-update-times-and-ids-of-elements branch 2 times, most recently from 5f5b3a2 to bdcfc34 Compare March 4, 2024 16:31
@horenso

horenso commented Mar 7, 2024

Copy link
Copy Markdown
Contributor Author

jenkins build please

@horenso

horenso commented Mar 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I added tests, I think this can be merged (if CI runs through let's see)

@markus2330

markus2330 commented Mar 10, 2024

Copy link
Copy Markdown
Contributor

jenkins build please

@horenso horenso added please merge and removed please review Review by unspecified person requested labels Mar 27, 2024
@markus2330

markus2330 commented Mar 29, 2024

Copy link
Copy Markdown
Contributor

@horenso unfortunately there is a merge conflict now... 😢

@horenso
horenso force-pushed the feature/1168-creation-and-update-times-and-ids-of-elements branch from 426eedd to feb1d8c Compare March 31, 2024 14:04
@horenso

horenso commented Apr 5, 2024

Copy link
Copy Markdown
Contributor Author

jenkins build please

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@markus2330 markus2330 Awaiting requested review from markus2330
@Bushuo Bushuo Awaiting requested review from Bushuo
1 more reviewer
@chr-schr chr-schr chr-schr approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

creation and update times of elements

4 participants

@horenso @markus2330 @chr-schr @Bushuo