ccan: fix read_all() to always set errno on failure #3330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
read(2) will return 0 to designate end-of-file and in this case it will not set errno. This is not considered as an error condition by read(2) itself, but all callers of read_all() expect that exactly the requested number of bytes will be read into the buffer, not less, so set errno to EBADMSG "Bad message" in this case. Related to ElementsProject#3185
Contributor
Author
|
I chose maybe |
Member
|
Thanks for the PR @vasild. This is part of ccan which is tracked externally at https://github.com/rustyrussell/ccan. Could you open a PR there? If accepted we'd update the in-tree version from the upstream version in a second step. |
cdecker
added
the
state::upstream
Contributor
Author
|
@cdecker yes, sorry for the confusion. continues at: rustyrussell/ccan#86 |
Member
|
No problem ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read(2) will return 0 to designate end-of-file and in this case it will
not set errno.
This is not considered as an error condition by read(2) itself, but all
callers of read_all() expect that exactly the requested number of bytes
will be read into the buffer, not less, so set errno to EBADMSG
"Bad message" in this case.
Related to #3185