Fix feature_set allocation on getmanifest callback #8590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `tal_dup_or_null` does not set the tal context to the included bytes array. Luckily we already have a function tha deeply duplicates a `feature_set`: `feature_set_dup` Signed-off-by: Peter Neuroth <[email protected]>
nepet
changed the title
a plugin is disabled during init. Signed-off-by: Peter Neuroth <[email protected]>
nepet
changed the title
rustyrussell
approved these changes
Oct 9, 2025
tests/plugins/feature-test.py
Outdated
|
|
||
| @plugin.init() | ||
| def init(configuration, options, plugin): | ||
| disable = os.getenv("PLUGIN_DISABLE") |
There was a problem hiding this comment.
This works, but a normal parameter would be more usual?
There was a problem hiding this comment.
f9e938c refactors the test-plugin to use an option instead of an env var.
Signed-off-by: Peter Neuroth <[email protected]>
rustyrussell
force-pushed
the
2540-fix-feature-bit-dup
branch
from
f9e938c to
a68f529
Compare
|
I removed the unneeded "import os" which was making flake8 upset... Ack a68f529 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
tal_dup_or_nulldoes not set the tal context to the included bytes array. Luckily we already have a function that deeply duplicates afeature_set:feature_set_dupSetting
Changelog-Noneas the feature has been introduced and fixed on the same version.Changelog-None