Skip to content

Fixed: enableoffer: Adding an error when trying to activate an used single use offer #8813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
21M4TW wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed: enableoffer: Adding an error when trying to activate an used single use offer #8813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions common/jsonrpc_errors.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ enum jsonrpc_errcode {
OFFER_BAD_INVREQ_REPLY = 1004,
OFFER_TIMEOUT = 1005,
OFFER_ALREADY_ENABLED = 1006,
OFFER_USED_SINGLE_USE = 1007,

/* Errors from datastore command */
DATASTORE_DEL_DOES_NOT_EXIST = 1200,
Expand Down
4 changes: 4 additions & 0 deletions lightningd/offer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,10 @@ static struct command_result *json_enableoffer(struct command *cmd,
return command_fail(cmd, OFFER_ALREADY_ENABLED,
"offer already active");

if (offer_status_single(status) && offer_status_used(status))
return command_fail(cmd, OFFER_USED_SINGLE_USE,
"cannot activate an used single use offer");

if (command_check_only(cmd))
return command_check_done(cmd);

Expand Down
Loading