Add alert for deleting a product category - #20
Open
ElisaKazan wants to merge 2 commits into
Open
Conversation
| .onDelete(perform: removeCategory) | ||
| .onDelete { indexSet in | ||
| deletedIndexSet = indexSet | ||
| showingDeleteAlert = true |
There was a problem hiding this comment.
hmm, this is the issue, changing 2 state properties. A change to a state prop tells the view to re-render. Somehow this is causing the showingDeleteAlert to get set to false. I wonder what the solution is
There was a problem hiding this comment.
crazy question, I wonder if reversing these makes a difference
There was a problem hiding this comment.
StackOverflow says this works, but it is hacky
DispatchQueue.main.asyncAfter(deadline: .now() + 0.5) {
showingDeleteAlert = true
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an alert dialog when deleting a product category. This gives us an extra layer of protection since it will also delete all of the products in the category.
Screenshots
Tried a Confirmation Dialog but didn't like how it looked.