Skip to content

Commit

Permalink
Slight GPIO cleanup, un-stabilize Io (esp-rs#3021)
Browse files Browse the repository at this point in the history
* Clean up, add fixme

* Destabilize Io, add inherent set_interrupt_handler

* Explicitly mark functions, not the impl block
  • Loading branch information
bugadani authored Jan 23, 2025
1 parent 2bb0a55 commit e842ec4
Show file tree
Hide file tree
Showing 13 changed files with 148 additions and 197 deletions.
7 changes: 7 additions & 0 deletions esp-hal/src/gpio/interconnect.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
//! Peripheral signal interconnect using IOMUX or GPIOMUX.
// FIXME: https://github.com/esp-rs/esp-hal/issues/2954 The GPIO implementation does not contain any
// locking. This is okay there, because the implementation uses either W1TS/W1TC
// registers to set certain bits, or separate registers for each pin - and there
// can only be one instance of every GPIO struct in safe code. However, with the
// interconnect module we allow multiple handles, which means possible RMW
// operations on the pin registers cause data races.

use crate::{
gpio::{
self,
Expand Down
Loading

0 comments on commit e842ec4

Please sign in to comment.