Skip to content

Fix copilot instructions #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hiyouga merged 1 commit into from
Jan 1, 2026
Merged

Fix copilot instructions #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ curl -LsSf https://astral.sh/uv/install.sh | sh
- **Check code style**: Run `make style` to check code formatting and linting
- **Auto-format code**: Run `make format` to automatically format code and fix linting issues
- **Build package**: Run `make build` to build the package
- **Run tests**: Run `make test` to run all tests
- **Run tests**: Run `make test` to run unit tests
- **Help**: Run `make help` to see available make commands

All make commands use `uv` internally to run tools in an isolated environment.
Expand All @@ -75,4 +75,11 @@ The project is configured in `pyproject.toml` with:
- Line length: 119 characters
- Target Python version: 3.11
- Google Python style standards
- Import sorting with isort
- Import sorting with isort

### Testing

- Run linting: `make style`
- Format code: `make format`
- Run Python scripts: `uv run python <script>.py`
- Run unit tests: `make test`
Comment on lines +82 to +85
Copy link

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new "Testing" section duplicates information already present in the "Using Make Commands" section (lines 64-68). The commands for linting, formatting, and running tests are already documented above. Consider removing this redundant section or consolidating it with the existing "Using Make Commands" section to maintain a single source of truth for these commands.

Suggested change
- Run linting: `make style`
- Format code: `make format`
- Run Python scripts: `uv run python <script>.py`
- Run unit tests: `make test`
- Run Python scripts via `uv`: `uv run python <script>.py`

Copilot uses AI. Check for mistakes.
Loading