Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue 420: UART ZEPHYR Transport will (most likely) stop to work after a few transactions when using USB-CDC #421

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

ghost
Copy link

@ghost ghost commented Apr 7, 2024

fixes issue 420.

fixes: #420

Pull request

Choose Correct

  • [x ] bug
  • feature

Describe the pull request

To Reproduce

see #420

Expected behavior

see #420

Screenshots

N/A

Desktop (please complete the following information):

see #420

Steps you didn't forgot to do

  • [ x] I checked if other PR isn't solving this issue.
  • [ x] I read Contribution details and did appropriate actions.
  • [ x] PR code is tested.
    But only on my HW setup ...
  • [ x] PR code is formatted.
  • Allow edits from maintainers pull request option is set (recommended).
    Can't set this option - I think because the fork is owned by my org, not me as individual

Additional context

N/a

fixes issue 420.
Not yet happy about error handling though ....

fixes: EmbeddedRPC#420
@MichalPrincNXP MichalPrincNXP self-assigned this Apr 12, 2024
@MichalPrincNXP MichalPrincNXP marked this pull request as draft April 12, 2024 10:22
@MichalPrincNXP
Copy link
Member

Hello @rene-becker-setec , thank for preparing this PR, it looks good ... could you format the code as per results of https://github.com/EmbeddedRPC/erpc/actions/runs/8588230594/job/23746634738?pr=421 or to allow the editing for me to do so? Thank you
Michal

@ghost
Copy link
Author

ghost commented Apr 12, 2024

Hello @rene-becker-setec , thank for preparing this PR, it looks good ... could you format the code as per results of https://github.com/EmbeddedRPC/erpc/actions/runs/8588230594/job/23746634738?pr=421 or to allow the editing for me to do so? Thank you
Michal

Hi @MichalPrincNXP ,
Done.
Would give you editing access if I could figure out how to.
Cheers,
Rene

@MichalPrincNXP
Copy link
Member

Hello @rene-becker-setec , thank for preparing this PR, it looks good ... could you format the code as per results of https://github.com/EmbeddedRPC/erpc/actions/runs/8588230594/job/23746634738?pr=421 or to allow the editing for me to do so? Thank you
Michal

Hi @MichalPrincNXP , Done. Would give you editing access if I could figure out how to. Cheers, Rene

I am still not able to edit, please use this formatted version:
erpc_uart_zephyr_transport.zip

this time replacing file with one provided via
EmbeddedRPC#421 (comment)
@ghost
Copy link
Author

ghost commented Apr 13, 2024

Hello @rene-becker-setec , thank for preparing this PR, it looks good ... could you format the code as per results of https://github.com/EmbeddedRPC/erpc/actions/runs/8588230594/job/23746634738?pr=421 or to allow the editing for me to do so? Thank you
Michal

Hi @MichalPrincNXP , Done. Would give you editing access if I could figure out how to. Cheers, Rene

I am still not able to edit, please use this formatted version: erpc_uart_zephyr_transport.zip

OK, updated file with the one you supplied.
Reading GitHub documentation it looks like I am not able to 'allow editing' as my fork is organization owned, not individually. Will have to use a different method next time.

@MichalPrincNXP MichalPrincNXP marked this pull request as ready for review April 17, 2024 07:29
@MichalPrincNXP MichalPrincNXP merged commit 4630822 into EmbeddedRPC:develop Apr 17, 2024
6 of 8 checks passed
@MichalPrincNXP
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] UART ZEPHYR Transport will (most likely) stop to work after a few transactions when using USB-CDC
1 participant