Skip to content

Update job types #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update job types #47

wants to merge 1 commit into from

Conversation

carlobortolan
Copy link
Member

Change job.job_id to job.id.

Warning

This PR needs to be merged simultaneously with Embloy/Embloy-Core-Server#167.

@carlobortolan carlobortolan added the enhancement New feature or request label Nov 15, 2024
@carlobortolan carlobortolan self-assigned this Nov 15, 2024
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
embloy-genius-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 6:58pm

@github4touchdouble
Copy link
Member

@carlobortolan: still relevant???

@carlobortolan
Copy link
Member Author

carlobortolan commented Dec 22, 2024

@carlobortolan: still relevant???

This PR was initially created after we changed our API to return a job id as id instead of job_id to keep it consistent with other models (e.g., user.id, option.id, etc.), but it depends on what you did in the dev branch. If everything works fine there (=if you already implemented the change), we can ignore this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants