fix: use optional param instead of overload for loadfile - #1011
Merged
Merged
Conversation
… param count check
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Lua standard library definitions by removing redundant whitespace and marking the filename parameter as optional in the loadfile function. Feedback suggests further improving type safety by specifying more precise types for the mode and env parameters to ensure consistency with the load function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace overloaded signatures of
loadfilewith optional parameters, so that the param count checker works correctly.