Fixes create and destroy#54
Closed
kyres1 wants to merge 1 commit into
Closed
Conversation
Author
|
works on my machine but ok lmao |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Just straight up obliterates the templates from domotan_east's fourth zlevel, added in #30 .
This somehow breaks the create_and_destroy test with the current map generators, and the issue revolves around icon smoothing turfs specifically. There were two options; remove the
/obj/effect/landmark/map_load_mark/necropolis/z4or remove the procedural/obj/effect/landmark/mapGenerator/cave. I chose the former temporarily because it's easier to fix probably.Why It's Good For The Game
broke test
Changelog
🆑
fix: fixes broken ci test by disabling necropolis z4 templates
/:cl:
Pre-Merge Checklist