-
-
Notifications
You must be signed in to change notification settings - Fork 3
refactor: port to WE-like build logic #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Revert applying checkstyle to :core-ap:processor/test/resources/gen
a1e37b2 to
dcaca20
Compare
|
Is there a reason for this refactor? I would generally prefer to make working conventions plugins rather than just copy the logic over (this has been in the works for a bit, but still not complete https://github.com/EngineHub/Crankcase). Additionally, I personally am against depending on Palantir's stuff, just because of what they do. If fixes need to happen I wouldn't want to contribute back to them. |
|
Totally fair—I was surprised they weren't in conventions plugins! I was just following WG's precedent. Re Palantar: Square's version is no longer maintained and seems to be reccomending Palantir's as a replacement. Happy to revert that or switch out to another though. As to reason, I was contemplating taking a look at porting WG over (see Discord #enginehub-misc) and thought I should make sure everything here is up to date first, in case adjustments are needed. |
|
I think the build logic here is generally simple enough that it shouldn't be necessary to update so much here just in case future changes need to be made. The only major thing would be the switch over to LevelHeadered for license header management. Introducing checkstyle should be doable without that, and I don't think we should do any immediate dependency updates if they're not needed. I'd prefer to keep it stable. |
I ran into some issues with core-ap processor tests when porting over the checkstyle config, so I suppressed check style for them and reverted back to the upstream versions.
I'm not sure if I missed anything—this is my first time dealing with some of these technologies and concepts.
All compiles and tests pass on my end.