Skip to content

Conversation

@mishyy
Copy link

@mishyy mishyy commented Dec 28, 2025

  • update to Gradle 9.2.1 and Java 17
  • switch to build-logic and PCS plugins
  • copy over and apply checkstyle config (?)

I ran into some issues with core-ap processor tests when porting over the checkstyle config, so I suppressed check style for them and reverted back to the upstream versions.

I'm not sure if I missed anything—this is my first time dealing with some of these technologies and concepts.

All compiles and tests pass on my end.

@mishyy mishyy force-pushed the feat/port-build-logic branch from a1e37b2 to dcaca20 Compare December 28, 2025 15:43
@octylFractal
Copy link
Member

Is there a reason for this refactor? I would generally prefer to make working conventions plugins rather than just copy the logic over (this has been in the works for a bit, but still not complete https://github.com/EngineHub/Crankcase).

Additionally, I personally am against depending on Palantir's stuff, just because of what they do. If fixes need to happen I wouldn't want to contribute back to them.

@mishyy
Copy link
Author

mishyy commented Dec 29, 2025

Totally fair—I was surprised they weren't in conventions plugins! I was just following WG's precedent.

Re Palantar: Square's version is no longer maintained and seems to be reccomending Palantir's as a replacement. Happy to revert that or switch out to another though.

As to reason, I was contemplating taking a look at porting WG over (see Discord #enginehub-misc) and thought I should make sure everything here is up to date first, in case adjustments are needed.

@octylFractal
Copy link
Member

I think the build logic here is generally simple enough that it shouldn't be necessary to update so much here just in case future changes need to be made. The only major thing would be the switch over to LevelHeadered for license header management.

Introducing checkstyle should be doable without that, and I don't think we should do any immediate dependency updates if they're not needed. I'd prefer to keep it stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants