Add setBiome override in MaskingExtent. #2709
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes biome operations respect masks set on an EditSession.
Previously,
//setbiome
directly masked its own operation, but/brush biome
(or anything else directly usingBiomeFactory
orBiomeReplace
) would manually have to do this masking as well (which/br biome
didn't). While we could manually add contextual masking to/br biome
(i.e. by modifyingBiomeFactory#createFromContext
), I think a unified solution like this PR is better in the long-term than the patchwork approach. Technically, however, this is a behavioral change, but judging by all the times people have asked why this doesn't work, I think the new behavior is the expected one.