Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setBiome override in MaskingExtent. #2709

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Conversation

wizjany
Copy link
Collaborator

@wizjany wizjany commented Feb 1, 2025

This makes biome operations respect masks set on an EditSession.

Previously, //setbiome directly masked its own operation, but /brush biome (or anything else directly using BiomeFactory or BiomeReplace) would manually have to do this masking as well (which /br biome didn't). While we could manually add contextual masking to /br biome (i.e. by modifying BiomeFactory#createFromContext), I think a unified solution like this PR is better in the long-term than the patchwork approach. Technically, however, this is a behavioral change, but judging by all the times people have asked why this doesn't work, I think the new behavior is the expected one.

@wizjany wizjany requested a review from a team as a code owner February 1, 2025 23:11
This makes biome operations respect masks set on an EditSession.
@wizjany wizjany merged commit dc92f6f into version/7.3.x Feb 2, 2025
5 checks passed
@wizjany wizjany deleted the fix/setbiome-mask branch February 2, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants