Fixed arg order error #6919
Merged
Fixed arg order error #6919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`postgres` the image name has to be at the end of all the options because any arguments after the image name is interpreted as the command to be run. Prior to the fix, `POSTGRES_PASSWORD` will be interpreted as commands and fail to set resulting in a container that won't start. After the fix, the environment variable will be correctly parsed into the compose file and can be seen in `docker inspect`. Additionally, I removed the extra escapes (i.e., `\`) that aren't needed in the bash command.
nidhibhammar
added
the
deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postgresthe image name has to be at the end of all the options because any arguments after the image name is interpreted as the command to be run.Prior to the fix,
POSTGRES_PASSWORDwill be interpreted as commands and fail to set resulting in a container that won't start.After the fix, the environment variable will be correctly parsed into the compose file and can be seen in
docker inspect.Additionally, I removed the extra escapes (i.e.,
\) that aren't needed in the bash command.What Changed?
postgresto the end of the command in two locationsdocker execcommandIssue addressed
#6920