Skip to content

Add guidance for restore and initial load #6945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Add guidance for restore and initial load #6945

wants to merge 10 commits into from

Conversation

eatonphil
Copy link
Contributor

No description provided.

@eatonphil eatonphil requested a review from a team as a code owner August 20, 2025 00:03
PJMODOS
PJMODOS reviewed Aug 21, 2025
View reviewed changes
@eatonphil eatonphil force-pushed the dev/pe/dump-restore branch from 49c8e7a to 4b8237e Compare August 28, 2025 23:55
irionr
irionr reviewed Sep 9, 2025
View reviewed changes
Copy link
Contributor

@irionr irionr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would start by configuring/setting the node first and only after that showing the pg_dump/restore commands

irionr
irionr reviewed Sep 9, 2025
View reviewed changes
irionr
irionr reviewed Sep 9, 2025
View reviewed changes
@eatonphil
Copy link
Contributor Author

I would start by configuring/setting the node first and only after that showing the pg_dump/restore commands

I don't understand what you mean here sorry

@irionr
Copy link
Contributor

irionr commented Sep 10, 2025

I would start by configuring/setting the node first and only after that showing the pg_dump/restore commands

I don't understand what you mean here sorry

This is minor. I meant we should first tell them how to configure the nodes, and only after that, to show them the dump and restore commands. Also, I would temporarily adjust these settings even if they use the "pre/data/post" method.
It's only a cosmetic thing probably , but users will just start reading and copying/running the commands before reaching the configuration point.

@eatonphil
Copy link
Contributor Author

Wait don't merge this one yet please @julienmarcbrown

@eatonphil
Copy link
Contributor Author

This is minor. I meant we should first tell them how to configure the nodes, and only after that, to show them the dump and restore commands. Also, I would temporarily adjust these settings even if they use the "pre/data/post" method.
It's only a cosmetic thing probably , but users will just start reading and copying/running the commands before reaching the configuration point.

No this is a good point, modified.

@eatonphil
Copy link
Contributor Author

I've addressed all PR feedback on the PGD side now @julienmarcbrown , good for a final docs review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJMODOS PJMODOS PJMODOS left review comments

@irionr irionr irionr left review comments

@julienmarcbrown julienmarcbrown julienmarcbrown approved these changes

@mwanner mwanner Awaiting requested review from mwanner

@vadim4o vadim4o Awaiting requested review from vadim4o

@vaijayanti-b vaijayanti-b Awaiting requested review from vaijayanti-b

@pavanvd pavanvd Awaiting requested review from pavanvd

@wind39 wind39 Awaiting requested review from wind39

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eatonphil @irionr @PJMODOS @julienmarcbrown