Skip to content

Fixing access-scope bug in EppoClient. #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JThramer wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixing access-scope bug in EppoClient. #82

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f796517
Update EppoClient.swift
JThramer Nov 12, 2025
c94fe54
updating with new solution candidate
Nov 13, 2025
8a9040e
reverting change made to internal var
Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions Sources/eppo/EppoClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ public class EppoClient {
assignmentCache: AssignmentCache? = InMemoryAssignmentCache(),
initialConfiguration: Configuration?,
withPersistentCache: Bool = true,
loadInitialConfigurationImmediately: Bool = false,
debugCallback: ((String, Double, Double) -> Void)? = nil
) {
self.sdkKey = SDKKey(sdkKey)
Expand All @@ -73,9 +74,18 @@ public class EppoClient {
self.configurationRequester = ConfigurationRequester(httpClient: httpClient)

self.configurationStore = ConfigurationStore(withPersistentCache: withPersistentCache)
if let configuration = initialConfiguration {
self.configurationStore.setConfiguration(configuration: configuration)
// Note: Callbacks will be registered after init, so initial config callback will be triggered during loadIfNeeded
if loadInitialConfigurationImmediately {
configurationStore.loadInitialConfiguration()
// cache miss?
if configurationStore.getConfiguration() == nil,
let initialConfiguration {
configurationStore.setConfiguration(configuration: initialConfiguration)
}
} else { //immediate cache load disabled
if let configuration = initialConfiguration {
self.configurationStore.setConfiguration(configuration: configuration)
// Note: Callbacks will be registered after init, so initial config callback will be triggered during loadIfNeeded
}
}

// Set up debug logging for ConfigurationRequester and ConfigurationStore after all properties are initialized
Expand Down Expand Up @@ -113,6 +123,7 @@ public class EppoClient {
assignmentCache: assignmentCache,
initialConfiguration: initialConfiguration,
withPersistentCache: withPersistentCache,
loadInitialConfigurationImmediately: true,
debugCallback: debugCallback
)

Expand Down