feat: Add CORS configuration, HTTPS/HSTS enforcement and fix hardcoded WebSocket URL#199
Merged
Merged
Conversation
…d} (Epta-Node#161) The ownership check (walletpublickey header required, must match task owner) was already implemented in the route handler. This commit adds the missing HTTP 403 response to the JSDoc annotation so the generated OpenAPI spec accurately documents the auth behaviour for consumers. Closes Epta-Node#161
- backend/src/api/middleware/cors.ts: CORS factory with configurable ALLOWED_ORIGINS, credentials, and custom headers (walletpublickey, x-challenge, x-signature) - backend/src/api/app.ts: mount CORS middleware and HSTS header middleware (production-only, max-age=31536000 + includeSubDomains + preload) - backend/src/config/index.ts: ALLOWED_ORIGINS Zod field with default http://localhost:3000 - backend/.env.example: document ALLOWED_ORIGINS under Security section - frontend/src/hooks/useTaskMonitor.ts: replace hardcoded ws://localhost:3001 with dynamic protocol/host (wss: on HTTPS, VITE_WS_HOST override) - backend/tests/cors.test.ts: add tests for allowed origin, blocked origin, no-origin passthrough, credentials header, preflight OPTIONS, default origin fallback, HSTS in production, and HSTS absent in development
|
@DevSolex is attempting to deploy a commit to the Jaja's projects Team on Vercel. A member of the Team first needs to authorize it. |
devJaja
self-requested a review
July 24, 2026 12:01
Contributor
|
LGTM |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #160
Implements all acceptance criteria from issue #160 — CORS configuration, HSTS enforcement, and the hardcoded WebSocket URL fix.
Changes
Backend
backend/src/api/middleware/cors.ts— CORS factory with configurableALLOWED_ORIGINS,credentials: true, allowed methods (GET POST PUT DELETE OPTIONS), and custom headers (walletpublickey,x-challenge,x-signature)backend/src/api/app.ts— Mounts CORS middleware globally; adds HSTS header middleware (max-age=31536000; includeSubDomains; preload) in production onlybackend/src/config/index.ts—ALLOWED_ORIGINSZod field with defaulthttp://localhost:3000backend/.env.example— DocumentsALLOWED_ORIGINSunder the Security sectionFrontend
frontend/src/hooks/useTaskMonitor.ts— Replaces hardcodedws://localhost:3001with dynamic protocol/host (wss:on HTTPS,ws:on HTTP,VITE_WS_HOSTenv override)Tests
backend/tests/cors.test.ts— 8 tests covering:access-control-allow-credentialsheader present for allowed originsOPTIONSresponse includes allowed methodsALLOWED_ORIGINSis unsetTesting
All 8 CORS/HSTS tests pass. No regressions in the wider test suite.