This repository was archived by the owner on Jan 15, 2024. It is now read-only.
Build project on windows #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorKoenders
force-pushed
the
ci-windows-implement
branch
from
17deb24 to
2974e41
Compare
VictorKoenders
force-pushed
the
ci-windows-implement
branch
from
2974e41 to
b9172a7
Compare
|
@VictorKoenders : We don't have hosted windows runners, and that is a thing I would like to avoid. In general if we can use the github hosted runners that is preferred over using self hosted runners. |
VictorKoenders
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to see how much work it would be to update to phaselock 0.0.8, and I noticed the project did not build on windows.
The only crate that is having issues is
signal-hook-async-std. It seems like they are not giving windows support a high priority, because windows has a complicated signal integration (source)This PR makes the build and tests on windows succeed, but does not bother to support the interrupt signal properly.
@Ancient123 do we have self hosted windows runners, or is it fine to run this on github's runner?