Skip to content

Remove TEE checks on batch posting #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jbearer
Copy link
Member

@jbearer jbearer commented Jun 12, 2025

No description provided.

Copy link
Collaborator

@Sneh1999 Sneh1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments but apart from the tests need to be fixed - rest looks good

@@ -380,41 +380,13 @@ contract SequencerInbox is
IGasRefunder gasRefunder,
uint256 prevMessageCount,
uint256 newMessageCount,
bytes memory espressoMetadata
uint256 hotshotHeight
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are passing the hotshot height here, we also need to emit it in the function?

@@ -70,7 +70,10 @@ interface ISequencerInbox is IDelayedMessageProvider {
event InvalidateKeyset(bytes32 indexed keysetHash);

/// @dev Signature from a registered ephemeral key generated inside TEE was verified over the batch data hash
event TEESignatureVerified(uint256 indexed sequenceNumber, uint256 indexed hotshotHeight);
event TEESignatureVerified(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the name of this event?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants