Attempt to fix issue with refactor on linux

When attempting to run the refactor on a linux machine, some errors are
encountered.  When Asking @philippecamacho about the errors
encountered he provided the error:
 `"unable to determine the host for the espresso-dev-node sequencer api"`

 This error occurs when the remapping has failed.  Comparing the
 refactor changes against the original implementation indicated
 a slight change in the logic.  The change is meant to ensure that
 the port is populated correctly on the container port map.  However
 it only checks the remapped values which are always populated with
 the given value.  This makes this condition a tautological expression
 which will never remap when it should.

 This fix changes the inspected value, and also adds a fail-safe to
 always process the re-assignment when the `network` is set to
 `"host"`.

Author: Ayiga

espresso/environment/optitmism_espresso_test_helpers.go

@@ -780,21 +780,24 @@ func determineDockerNetworkMode() string {
 // remapped port values.  This is done for convenience in order to ensure that
 // we can still reference the hard coded ports, even if they've been remapped
 // from their original values.
-func ensureHardCodedPortsAreMappedFromTheirOriginalValues(containerInfo *DockerContainerInfo, portRemapping map[string]string) {
-	if _, ok := portRemapping[ESPRESSO_SEQUENCER_API_PORT]; !ok {
-		// If we don't have the original port mapping for the hard
-		// coded port, we will need to back fill them in, just
-		// to make life easier for consumers.
-
-		for portKey, portValue := range portRemapping {
-			// We copy the port mapping information
-			// so we know the original mapping again,
-			// since we're hard-coding the ports to use.
-			// This should allow us to run multiple
-			// e2e test environments in parallel on
-			// linux as well.
-			containerInfo.PortMap[portKey] = containerInfo.PortMap[portValue]
-		}
+func ensureHardCodedPortsAreMappedFromTheirOriginalValues(containerInfo *DockerContainerInfo, portRemapping map[string]string, network string) {
+	if network != "host" {
+		// nothing needs to be modified
+		return
+	}
+
+	// If we don't have the original port mapping for the hard
+	// coded port, we will need to back fill them in, just
+	// to make life easier for consumers.
+
+	for portKey, portValue := range portRemapping {
+		// We copy the port mapping information
+		// so we know the original mapping again,
+		// since we're hard-coding the ports to use.
+		// This should allow us to run multiple
+		// e2e test environments in parallel on
+		// linux as well.
+		containerInfo.PortMap[portKey] = containerInfo.PortMap[portValue]
 	}
 }
 
@@ -840,8 +843,9 @@ func launchEspressoDevNodeStartOption(ct *DevNetLauncherContext) e2esys.StartOpt
 				return
 			}
 
-			ensureHardCodedPortsAreMappedFromTheirOriginalValues(&espressoDevNodeContainerInfo, portRemapping)
+			ensureHardCodedPortsAreMappedFromTheirOriginalValues(&espressoDevNodeContainerInfo, portRemapping, network)
 
+			// Wait for Espresso to be ready
 			if err := waitForEspressoToFinishSpinningUp(ct, espressoDevNodeContainerInfo); err != nil {
 				ct.Error = err
 				return
@@ -854,7 +858,8 @@ func launchEspressoDevNodeStartOption(ct *DevNetLauncherContext) e2esys.StartOpt
 
 			espressoDevNode := &EspressoDevNodeDockerContainerInfo{
 				DockerContainerInfo: espressoDevNodeContainerInfo,
-				espressoUrls:        []string{"http://" + hostPort},
+				// To create a valid multiple nodes client, we need to provide at least 2 URLs.
+				espressoUrls: []string{"http://" + hostPort, "http://" + hostPort},
 			}
 			ct.EspressoDevNode = espressoDevNode